Re: [PATCH] move IMMUTABLE|APPEND checks to notify_change()

[Kirill Korotaev <dev@sw.ru>]

Al Viro wrote:
> On Tue, Aug 08, 2006 at 03:44:07PM +0400, Kirill Korotaev wrote:
> 
>>[PATCH] move IMMUTABLE|APPEND checks to notify_change()
>>
>>This patch moves lots of IMMUTABLE and APPEND flag checks
>>scattered all around to more logical place in notify_change().
> 
>  
> NAK.  For example, you are allowed to do unames(file, NULL) on
> any file you own or can write to, whether it's append-only or
> not.  With your change that gets -EPERM.
> 

Does such check in notify_change() looks better for you?

notify_change():
        if (IS_IMMUTABLE(inode))
                return -EPERM;
        if (IS_APPEND(inode) &&
                        (ia_valid & ~(ATTR_CTIME | ATTR_MTIME | ATTR_ATIME)))
                return -EPERM;

Thanks,
Kirill