From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: rdunlap@xenotime.net, forrest.zhao@intel.com, htejun@gmail.com,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] libata: implement to get tf's from _GTF and execute them
Date: Wed, 09 Aug 2006 16:29:19 +0400 [thread overview]
Message-ID: <44D9D51F.9040309@ru.mvista.com> (raw)
In-Reply-To: <44D90B2E.1050708@pobox.com>
Hello.
Jeff Garzik wrote:
>>> diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
>>> index 386e5f2..cd4cf97 100644
>>> --- a/drivers/scsi/libata-core.c
>>> +++ b/drivers/scsi/libata-core.c
>>> @@ -91,6 +91,10 @@ static int ata_probe_timeout = ATA_TMOUT
>>> module_param(ata_probe_timeout, int, 0444);
>>> MODULE_PARM_DESC(ata_probe_timeout, "Set ATA probing timeout
>>> (seconds)");
>>> +int noacpi = 0;
>> Drop the "= 0". It will be init. to 0 anyway.
>> (Yes, I know my patch had that. :)
> Not necessarily true, since it is not static...
All uninitialized explicitly non-auto variables go into .bss section and
get initialized to 0 and 'static' has nothing to do with it, IIRC...
WBR, Sergei
next prev parent reply other threads:[~2006-08-09 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-26 7:36 [PATCH 1/2] libata: implement to get tf's from _GTF and execute them zhao, forrest
2006-08-08 19:19 ` Randy.Dunlap
2006-08-08 22:07 ` Jeff Garzik
2006-08-09 12:29 ` Sergei Shtylyov [this message]
2006-08-09 4:40 ` Jeff Garzik
2006-08-09 5:18 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D9D51F.9040309@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=forrest.zhao@intel.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.