From: Mark Lord <liml@rtr.ca>
To: albertl@mail.com
Cc: Jeff Garzik <jgarzik@pobox.com>,
Linux IDE <linux-ide@vger.kernel.org>,
Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH] libata: Use ATA_FLAG_PIO_POLLING for pdc_adma
Date: Wed, 09 Aug 2006 08:59:49 -0400 [thread overview]
Message-ID: <44D9DC45.9090703@rtr.ca> (raw)
In-Reply-To: <44D9BAA6.2050005@tw.ibm.com>
Albert Lee wrote:
> pdc_adma was overlooked and broken by the irq-pio patch:
> Only HSM_ST_LAST interrupts should be delivered to this LLDD.
>
> Adding ATA_FLAG_PIO_POLLING to pdc_adma fixes the problem (temporarily),
> before we convert the irq handler of pdc_adma to handle all interrupts.
>
> Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
Signed-off-by: Mark Lord <mlord@pobox.com>
Looks good. Note also that sata_qstor.c uses the same code structure,
and already does the same thing.
> ---
> Patch against 2.6.18-rc4 and tested ok by Tejun.
>
> --- linux-2.6.18-rc4/drivers/scsi/pdc_adma.c 2006-08-08 14:03:21.000000000 +0800
> +++ linux-2.6.18-rc4-adma-poll/drivers/scsi/pdc_adma.c 2006-08-08 14:05:13.000000000 +0800
> @@ -183,7 +183,8 @@ static struct ata_port_info adma_port_in
> {
> .sht = &adma_ata_sht,
> .host_flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_SRST |
> - ATA_FLAG_NO_LEGACY | ATA_FLAG_MMIO,
> + ATA_FLAG_NO_LEGACY | ATA_FLAG_MMIO |
> + ATA_FLAG_PIO_POLLING,
> .pio_mask = 0x10, /* pio4 */
> .udma_mask = 0x1f, /* udma0-4 */
> .port_ops = &adma_ata_ops,
>
next prev parent reply other threads:[~2006-08-09 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 10:36 [PATCH] libata: Use ATA_FLAG_PIO_POLLING for pdc_adma Albert Lee
2006-08-09 12:59 ` Mark Lord [this message]
2006-08-10 10:55 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D9DC45.9090703@rtr.ca \
--to=liml@rtr.ca \
--cc=albertl@mail.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.