All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: device-mapper development <dm-devel@redhat.com>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: request based multipath
Date: Thu, 10 Aug 2006 05:03:45 -0400	[thread overview]
Message-ID: <44DAF671.5000705@cs.wisc.edu> (raw)

I know I said I would not do it, but I was without internet access for
some time and the request based multipath stuff was the only code on my
computer, so I updated the code and fixed the locking and irq bugs.

I stuck it in the multipath branch of my iscsi tree here
http://kernel.org/git/?p=linux/kernel/git/mnc/linux-2.6-iscsi.git;a=summary
I am not looking for a formal review of the patches so I will not send
the patches to the list unless someone asks. I just updated the code due
to popular request and because I was testing the request struct timer
patch :)

It compiles. It works, but has not been tested very hard. There are lots
of things I did not handle because if we move it to dm then I need to
update some of that code to handle things properly. And there is a nasty
performance problem. I think this is due to me using the block layer
functions as-is in a little less than optimal way. It is about a 1-2%
drop for normal setups like when using qla2xxx or lpfc or iscsi, but
when using libata with very small IOs we hit some problems that I
believe are result of me using the block layer with no modifications to
the queueing, unplugging and locking. I will continue to look into this.

I did not hook this into Jens's cmd type stuff and my patch to move the
scsi hw handlers to the scsi layer. I did not have time. The code does
have us send the sense and request->errors to the multipath layer for
read and writes and failover IOs, and the io scheduler is in the correct
place now. I still have to hook into the dm layer or we have to figure
out what we are going to do about that - maybe just port multipath-tools
to the new multipath layer (this should not be too bad since we can add
a interface similar to dm's very easily).

So Alasdair tell me what you want to do and if you have time? If you are
busy Mike Anderson and I and the NEC guys could probably take this task
and that way we can get multipath development going again.

                 reply	other threads:[~2006-08-10  9:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44DAF671.5000705@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=dm-devel@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.