From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <jbeulich@novell.com>
Subject: Re: [PATCH] shared_info size and padding fixes
Date: Thu, 10 Aug 2006 10:31:41 +0200
Message-ID: <44DB0B0D.76E4.0078.0@novell.com>
References: <20060809210528.GA31314@totally.trollied.org>
	<200608101003.37572.Tristan.Gingold@bull.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <200608101003.37572.Tristan.Gingold@bull.net>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Tristan Gingold <Tristan.Gingold@bull.net>, xen-devel@lists.xensource.com, John Levon <levon@movementarian.org>
List-Id: xen-devel@lists.xenproject.org

>>  	DEFINE(IA64_SWITCH_STACK_SIZE, sizeof (struct switch_stack));
>>  	DEFINE(IA64_CPU_SIZE, sizeof (struct cpuinfo_ia64));
>>  	DEFINE(UNW_FRAME_INFO_SIZE, sizeof (struct unw_frame_info));
>> -	DEFINE(SHARED_INFO_SIZE, sizeof (struct shared_info));
>>
>>  	BLANK();
>>  	DEFINE(IA64_MCA_CPU_INIT_STACK_OFFSET, offsetof (struct
ia64_mca_cpu,
>
>Please, do not remove this define.  It is used to check the struct is
not 
>bigger than a page!

Checking this should be done with BUILD_BUG_ON() in a .c file, and
hence
not require an entry in asm-offsets.c.

Jan