From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <jbeulich@novell.com>
Subject: Re: [PATCH] shared_info size and padding fixes
Date: Thu, 10 Aug 2006 10:33:01 +0200
Message-ID: <44DB0B5D.76E4.0078.0@novell.com>
References: <20060809210528.GA31314@totally.trollied.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20060809210528.GA31314@totally.trollied.org>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: John Levon <levon@movementarian.org>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

>>> John Levon <levon@movementarian.org> 09.08.06 23:05 >>>
>sizeof(shared_info_t) can change even in compatible hypervisor
versions.
>Add a clear warning about this, and fix the few places relying on it.
>In addition, add some padding to arch_shared_info, to allow future
>additions to the structure without breaking known offsets of members
>following it in the shared info.

Shouldn't you also bump the ABI version with these compatibility
breaking
changes to the shared info structure?

Jan