From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, proski@gnu.org
Subject: Re: [PATCH] libata: replace pci_module_init() with pci_register_driver()
Date: Thu, 10 Aug 2006 06:39:31 -0400 [thread overview]
Message-ID: <44DB0CE3.8030908@pobox.com> (raw)
In-Reply-To: <20060810093359.GD6371@htj.dyndns.org>
Tejun Heo wrote:
> From: Pavel Roskin <proski@gnu.org>
>
> Replace pci_module_init() with pci_register_driver().
>
> Signed-off-by: Pavel Roskin <proski@gnu.org>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> ---
>
> This patch is against
>
> upstream (3f066887595de490c411762ce58a31412b09e939)
> + improve-init-and-legacy-handling patchset, take #3
> (http://article.gmane.org/gmane.linux.ide/12556)
>
> And avaliable in the following git tree.
>
> http://htj.dyndns.org/git/?p=libata-tj.git;a=shortlog;h=tj-upstream-pci_register_driver
> git://htj.dyndns.org/libata-tj tj-upstream-pci_register_driver
FWIW, it is actually better to -not- stack patchsets in this way.
git merging enables parallel branches. Since pci-register-driver
changes are completely unrelated to the improve-init-and-legacy-handling
patchset, it would make sense to have that in an independent branch.
Anyway, this is not an acceptance or rejection comment (I plan to merge
it). Just a comment. :)
Jeff
next prev parent reply other threads:[~2006-08-10 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 9:33 [PATCH] libata: replace pci_module_init() with pci_register_driver() Tejun Heo
2006-08-10 10:39 ` Jeff Garzik [this message]
2006-08-10 11:34 ` Tejun Heo
2006-08-10 10:59 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44DB0CE3.8030908@pobox.com \
--to=jgarzik@pobox.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.