Re: [PATCH 22/25] NFS: remove a no-longer-needed error check in nfs_symlink()

[Peter Staubach <staubach@redhat.com>]

Greg Banks wrote:
> On Thu, 2006-08-10 at 00:59, Chuck Lever wrote:
>   
>> In the early days of NFS, there was no duplicate reply cache on the server.
>> Thus retransmitted non-idempotent requests often found that the request had
>> already completed on the server.  To avoid passing an unanticipated return
>> code to unsuspecting applications, NFS clients would often shunt error
>> codes that implied the request had been retried but already completed.
>>
>> On modern NFS clients, it is safe to remove such checks.
>>     
>
> I'm not sure why you have such faith in servers' repcaches.  The Linux
> knfsd repcache as currently coded is fundamentally useless at modern
> call rates.  If this error case isn't needed anymore it's probably
> because we have fewer lost calls thanks to using TCP instead of UDP.
>   

It is true that the duplicate request cache in Linux and probably most other
systems, definitely including Solaris, is undersized.  However, most 
clients,
definitely including Solaris, do not contain special code.  They simply
depend upon the server to work correctly.

I suspect that it is the use of TCP which has minimized the number of
complaints about failing non-idempotent requests.  Given that TCP is 
becoming
more and more widespread, and that TCP is the only valid transport for 
NFSv4,
despite the Linux implementation, it seems to make sense to minimize the
overhead on the client.

       ps


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs