Re: [PATCH] 3/7 AU1100 MMC support

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Rodolfo Giometti wrote:

> Kernel messages fixup.

    I guess the MMC patches should go to the appropriate maintainer, Russel 
King <rmk+mmc@arm.linux.org.uk>.

> Signed-off-by: Rodolfo Giometti <giometti@linux.it>

> ------------------------------------------------------------------------
> 
> diff --git a/drivers/mmc/au1xmmc.c b/drivers/mmc/au1xmmc.c
> index 6084bb8..560d6e3 100644
> --- a/drivers/mmc/au1xmmc.c
> +++ b/drivers/mmc/au1xmmc.c
> @@ -54,13 +54,16 @@ #include "au1xmmc.h"
>  
>  #define DRIVER_NAME "au1xxx-mmc"
>  
> -/* Set this to enable special debugging macros */
> -
> -#ifdef DEBUG
> -#define DBG(fmt, idx, args...) printk("au1xx(%d): DEBUG: " fmt, idx, ##args)
> +#ifdef CONFIG_MMC_DEBUG
> +#define dbg(fmt, idx, args...) printk(KERN_DEBUG "%s(%d): DEBUG: " \
> +					fmt, DRIVER_NAME, idx, ##args)

    Could also use pr_debug() here. If DEBUG is #defined, it'll print what you 
need, if not then no.

>  #else
> -#define DBG(fmt, idx, args...)
> +#define dbg(fmt, idx, args...)
>  #endif
> +#define err(fmt, idx, args...) printk(KERN_DEBUG "%s(%d): ERROR: " \
> +					fmt, DRIVER_NAME, idx, ##args)

    Are you sure KERN_DEBUG fits best for error messages, not KERN_ERR?

> +#define info(fmt, idx, args...) printk(KERN_INFO "%s(%d): " \
> +					fmt, DRIVER_NAME, idx, ##args)

    Could use pr_info() there...

WBR, Sergei