From: "Jan Beulich" <jbeulich@novell.com>
To: "Chuck Ebbert" <76306.1226@compuserve.com>
Cc: "Andi Kleen" <ak@suse.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [patch] i386: annotate the rest of entry.s::nmi
Date: Thu, 10 Aug 2006 15:39:27 +0200 [thread overview]
Message-ID: <44DB532F.76E4.0078.0@novell.com> (raw)
In-Reply-To: <200608100851_MC3-1-C7A8-8B6A@compuserve.com>
>> >Part of the NMI handler is missing annotations. Just moving
>> >the RING0_INT_FRAME macro fixes it. And additional comments
>> >should warn anyone changing this to recheck the annotations.
>>
>> I have to admit that I can't see the value of this movement; the
>> code sequence in question was left un-annotated intentionally.
>> The point is that the push-es in FIX_STACK() aren't annotated, so
>> things won't be correct at those points anyway.
>
>I have a patch here that adds that, but it won't compile
>because that part of the NMI handler is un-annotated:
But you didn't clarify why you need this piece of code annotated...
Jan
next prev parent reply other threads:[~2006-08-10 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 12:48 [patch] i386: annotate the rest of entry.s::nmi Chuck Ebbert
2006-08-10 12:58 ` Andi Kleen
2006-08-10 13:39 ` Jan Beulich [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-08-11 23:13 Chuck Ebbert
2006-08-14 6:55 ` Jan Beulich
2006-08-10 17:39 Chuck Ebbert
2006-08-11 7:10 ` Jan Beulich
2006-08-10 4:59 Chuck Ebbert
2006-08-10 5:20 ` Andi Kleen
2006-08-10 8:23 ` Jan Beulich
2006-08-10 8:26 ` Andi Kleen
2006-08-10 8:34 ` Jan Beulich
2006-08-11 17:46 ` Stas Sergeev
2006-08-14 6:52 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44DB532F.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=76306.1226@compuserve.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.