From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <44DC2CF1.9070206@domain.hid> Date: Fri, 11 Aug 2006 09:08:33 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <44CF6EB1.1010808@domain.hid> <44D36389.3030706@domain.hid> <44D4A0E4.5070703@domain.hid> <44D4CAE9.9000800@domain.hid> <44D4E38D.9060007@domain.hid> <44D4FF53.8000904@domain.hid> <44D74B93.9070905@domain.hid> <44D74EC4.3010806@domain.hid> <44DC2AE0.6080709@domain.hid> In-Reply-To: <44DC2AE0.6080709@domain.hid> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig0FB24AB1A197B04FBAEE9AEB" Sender: jan.kiszka@domain.hid Subject: [Xenomai-core] Re: [Xenomai-help] [ANNOUNCE] RTDM driver for CAN devices List-Id: "Xenomai life and development \(bug reports, patches, discussions\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wolfgang Grandegger Cc: xenomai@xenomai.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0FB24AB1A197B04FBAEE9AEB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Wolfgang Grandegger wrote: > Jan Kiszka wrote: >> Wolfgang Grandegger wrote: >>> Jan Kiszka wrote: >>>> Wolfgang Grandegger wrote: >>>>>>>> - Well known issue: the RTCAN name. This should definitely get >>>>>>>> resolved >>>>>>>> before we merge. Any feedback already? >>>>>>> I contacted the author. If I will not get an answer soon, I tend >>>>>>> changing the global name to RT-Socket-CAN (rtsocketcan). >>>>>> I would really hate to have a drivers/rtsocketcan or a >>>>>> rtdm/rtsocketcan.h. The short name is so much nicer. >>>>> He did not say, that we cannot use the name RTCAN but he prefers >>>>> that we >>>>> use a different name to avoid confusion. Therefore I suggest to use= >>>>> the >>>>> offical name "RT-Socket-CAN" for the project, but leave almost all >>>>> internal rtcan prefixes as they are apart from: >>>>> >>>>> drivers/rtsocketcan >>>>> rtdm/rtsocketcan.h >>>>> >>>>> Note that the API does use the Linux naming in most cases (with the= >>>>> prefix can). >>>>> >>>>> Another possibility would be to use rtscan as short form for >>>>> rtsocketcan >>>>> as prefix. >>>>> >>>>> What do you think? Well, it's just a name. >>>> Never underestimate naming. Ok, I have this proposal now: >>>> >>>> o drivers/can/ - That's consistent with the existing subdir naming >>>> anyway. >>>> >>>> o rtdm/rtcan.h - The "rtdm/" prefix clearly defines the context: It= 's >>>> THE standard real-time CAN profile for RTDM. >>>> >>>> o All references to "RTCAN" in comments, READMEs, headers, etc. >>>> must be >>>> changed to RT-Socket-CAN. So it should be clear that this has >>>> nothing >>>> to do with the existing "rtcan" project. >>>> >>>> o Variable, type, and function names remain as they are. >>>> >>>> Jan >>>> >>>> >>>> PS: Another point for the long-term to-do list :-> : The nested lock= ing >>>> and the global scope of certain locks. It's safe, it's harmless for >>>> current primary target platforms (UP), but it's not really beautiful= >>>> when considering SMP setups. A bit tricky, for sure. >>> I just realized another issue. Where to put README and CREDITS file? = The >>> README should go into doc/txt/can-driver.txt. Should I add the credit= s >>> to this file as well? >> >> I would maintain that file under drivers/can. Who knows if it doesn't >> grow noticeably over the time... Some reference from the main CREDITS >> would be good then. Something like "See drivers//CREDITS fo= r >> further contributors". >=20 > Attached is a revised patch of RT-Socket-CAN for Xenomai ready for > integration. I fixed most of the issues as discussed. Still a few on th= e > TO-DO list, but they could be fixed later on, I think. >=20 Great! Will have a look later and start to merge it. What's the status of the utils? Philippe and I agreed to put them into src/utils/can. Jan --------------enig0FB24AB1A197B04FBAEE9AEB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFE3CzxniDOoMHTA+kRAuejAJ9/iahxjCsmbzjQ9Yo6ZBIPAjA0KgCfflYY 9wzNL9B2msxMAqXSMCyexsU= =c4I4 -----END PGP SIGNATURE----- --------------enig0FB24AB1A197B04FBAEE9AEB--