All of lore.kernel.org
 help / color / mirror / Atom feed
* Re : sparsemem usage
@ 2006-08-10 14:46 moreau francis
  2006-08-10 15:05 ` KAMEZAWA Hiroyuki
  2006-08-10 15:21 ` Andy Whitcroft
  0 siblings, 2 replies; 11+ messages in thread
From: moreau francis @ 2006-08-10 14:46 UTC (permalink / raw)
  To: KAMEZAWA Hiroyuki; +Cc: apw, alan, linux-kernel

KAMEZAWA Hiroyuki wrote:
> On Thu, 10 Aug 2006 14:40:52 +0200 (CEST)
> moreau francis <francis_moreau2000@yahoo.fr> wrote: 
>>> BTW, ioresouce information (see kernel/resouce.c)
>>>
>>> [kamezawa@aworks Development]$ cat /proc/iomem | grep RAM
>>> 00000000-0009fbff : System RAM
>>> 000a0000-000bffff : Video RAM area
>>> 00100000-2dfeffff : System RAM
>>>
>>> is not enough ?
>>>
>> well actually you show that to get a really simple information, ie does
>> a page exist ?, we need to parse some kernel data structures like 
>> ioresource (which is, IMHO, hackish) or duplicate in each architecture
>> some data to keep track of existing pages.
>>
> 
> becasue memory map from e820(x86) or efi(ia64) are registered to iomem_resource,
> we should avoid duplicates that information. kdump and memory hotplug uses
> this information. (memory hotplug updates this iomem_resource.)
> 
> Implementing "page_is_exist" function based on ioresouce is one of generic
> and rubust way to go, I think.
> (if performance of list walking is problem, enhancing ioresouce code is
>  better.)
>  

Why not implementing page_exist() by simply using mem_map[] ? When
allocating mem_map[], we can just fill it with a special value. And
then when registering memory area, we clear this special value with
the "reserved" value. Hence for flatmem model, we can have:

#define page_exist(pfn)        (mem_map[pfn] != SPECIAL_VALUE)

and it should work for sparsemem too and other models that will use
mem_map[].

Another point, is page_exist() going to replace page_valid() ?
I mean page_exist() is going to be something more accurate than
page_valid(). All tests on page_valid() _only_ will be fine to test
page_exist(). But all tests such:

    if (page_valid(x) && page_is_ram(x))

can be replaced by

    if (page_exist(x))

So, again, why not simply improving page_valid() definition rather
than introduce a new service ?

Francis





^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: Re : Re : sparsemem usage
@ 2006-08-03  9:47 Andy Whitcroft
  2006-08-03 12:46 ` Re : " moreau francis
  0 siblings, 1 reply; 11+ messages in thread
From: Andy Whitcroft @ 2006-08-03  9:47 UTC (permalink / raw)
  To: moreau francis; +Cc: Alan Cox, linux-kernel

moreau francis wrote:
> Alan Cox wrote:
>> Mapping out parts of a section is quite normal - think about the 640K to
>> 1Mb hole in PC memory space.
> 
> OK. But I'm still worry. Please consider the following code
> 
>        for (...; ...; ...) {
>                 [...]
>                 if (pfn_valid(i))
>                        num_physpages++;
>                 [...]
>         }
> 
> In that case num_physpages won't store an accurate value. Still it will be
> used by the kernel to make some statistic assumptions on other kernel
> data structure sizes.

That would be incorrect usage.  pfn_valid() simply doesn't tell you if 
you have memory backing a pfn, it mearly means you can interrogate the 
page* for it.  A good example of code which counts pages in a region is 
in count_highmem_pages() which has a form as below:

			for (pfn = start; pfn < end; pfn++) {
  				if (!pfn_valid(pfn))
                                         continue;
                                 page = pfn_to_page(pfn);
                                 if (PageReserved(page))
                                         continue;
				num_physpages++;
			}

-apw

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2006-08-16 12:56 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-10 14:46 Re : sparsemem usage moreau francis
2006-08-10 15:05 ` KAMEZAWA Hiroyuki
2006-08-10 15:23   ` Re : " moreau francis
2006-08-10 15:21 ` Andy Whitcroft
2006-08-10 15:37   ` Re : " moreau francis
2006-08-11  8:26     ` Andy Whitcroft
2006-08-11 12:46       ` Re : " moreau francis
2006-08-11 12:52         ` Andy Whitcroft
2006-08-16 12:56           ` Re : " moreau francis
  -- strict thread matches above, loose matches on Subject: below --
2006-08-03  9:47 Andy Whitcroft
2006-08-03 12:46 ` Re : " moreau francis
2006-08-03 13:13   ` Andy Whitcroft

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.