All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan-Bernd Themann <ossthema@de.ibm.com>
To: Michael Neuling <mikey@neuling.org>
Cc: Thomas Klein <tklein@de.ibm.com>, netdev <netdev@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-ppc <linuxppc-dev@ozlabs.org>,
	Christoph Raisch <raisch@de.ibm.com>,
	Marcus Eder <meder@de.ibm.com>
Subject: Re: [PATCH 3/6] ehea: queue management
Date: Fri, 11 Aug 2006 15:04:11 +0200	[thread overview]
Message-ID: <44DC804B.70609@de.ibm.com> (raw)
In-Reply-To: <20060811000540.200CE67B6B@ozlabs.org>

Hi,

>
>> +#define EHEA_EQE_SM_MECH_NUMBER  EHEA_BMASK_IBM(48, 55)
>> +#define EHEA_EQE_SM_PORT_NUMBER  EHEA_BMASK_IBM(56, 63)
>> +
>> +struct ehea_eqe {
>> +	u64 entry;
>> +};
> 
> ehea_ege.. what is that and why a struct if only 1 item?  Comments
> please.  
> 

There are send / receive queue elements (ehea_swqe, ehea_rwqe),
completion queue elements (ehea_cqe) and event queue elements (ehea_eqe).
We introduced struct ehea_eqe to get a consistent description for all
queue elements.

Jan-Bernd

WARNING: multiple messages have this Message-ID (diff)
From: Jan-Bernd Themann <ossthema@de.ibm.com>
To: Michael Neuling <mikey@neuling.org>
Cc: netdev <netdev@vger.kernel.org>, Thomas Klein <tklein@de.ibm.com>,
	linux-ppc <linuxppc-dev@ozlabs.org>,
	Christoph Raisch <raisch@de.ibm.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Marcus Eder <meder@de.ibm.com>
Subject: Re: [PATCH 3/6] ehea: queue management
Date: Fri, 11 Aug 2006 15:04:11 +0200	[thread overview]
Message-ID: <44DC804B.70609@de.ibm.com> (raw)
In-Reply-To: <20060811000540.200CE67B6B@ozlabs.org>

Hi,

>
>> +#define EHEA_EQE_SM_MECH_NUMBER  EHEA_BMASK_IBM(48, 55)
>> +#define EHEA_EQE_SM_PORT_NUMBER  EHEA_BMASK_IBM(56, 63)
>> +
>> +struct ehea_eqe {
>> +	u64 entry;
>> +};
> 
> ehea_ege.. what is that and why a struct if only 1 item?  Comments
> please.  
> 

There are send / receive queue elements (ehea_swqe, ehea_rwqe),
completion queue elements (ehea_cqe) and event queue elements (ehea_eqe).
We introduced struct ehea_eqe to get a consistent description for all
queue elements.

Jan-Bernd


  parent reply	other threads:[~2006-08-11 13:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-09  8:39 [PATCH 3/6] ehea: queue management Jan-Bernd Themann
2006-08-09  8:39 ` Jan-Bernd Themann
2006-08-11  0:05 ` Michael Neuling
2006-08-11  0:05   ` Michael Neuling
2006-08-11  0:32   ` Alexey Dobriyan
2006-08-11  0:32     ` Alexey Dobriyan
2006-08-11  0:46     ` Michael Neuling
2006-08-11  0:46       ` Michael Neuling
2006-08-11  7:28       ` Thomas Klein
2006-08-11  7:28         ` Thomas Klein
2006-08-11  9:21         ` Jörn Engel
2006-08-11  9:21           ` Jörn Engel
2006-08-11 13:04   ` Jan-Bernd Themann [this message]
2006-08-11 13:04     ` Jan-Bernd Themann
2006-08-11 16:09   ` Thomas Klein
2006-08-11 16:09     ` Thomas Klein
2006-08-11 21:52 ` Anton Blanchard
2006-08-11 21:52   ` Anton Blanchard
2006-08-12 16:37   ` Thomas Klein
2006-08-12 16:37     ` Thomas Klein
2006-08-13 14:44     ` Anton Blanchard
2006-08-13 14:44       ` Anton Blanchard
2006-08-14 12:38       ` ehea debug output discussion Jan-Bernd Themann
2006-08-14 12:38         ` Jan-Bernd Themann
2006-08-15  0:02         ` Michael Ellerman
2006-08-15  0:02           ` Michael Ellerman
2006-08-15  5:10         ` Paul Mackerras
  -- strict thread matches above, loose matches on Subject: below --
2006-06-21 12:03 [PATCH 3/6] ehea: queue management Jan-Bernd Themann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44DC804B.70609@de.ibm.com \
    --to=ossthema@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=meder@de.ibm.com \
    --cc=mikey@neuling.org \
    --cc=netdev@vger.kernel.org \
    --cc=raisch@de.ibm.com \
    --cc=tklein@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.