From: Patrick McHardy <kaber@trash.net>
To: Mark Huang <mlhuang@CS.Princeton.EDU>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] Fix ipt_ULOG panics on SMP kernels
Date: Fri, 11 Aug 2006 19:13:30 +0200 [thread overview]
Message-ID: <44DCBABA.4090207@trash.net> (raw)
In-Reply-To: <44DCB42B.7010009@cs.princeton.edu>
Mark Huang wrote:
> Fix kernel panic on various SMP machines. The culprit is a null
> ub->skb in ulog_send(). If ulog_timer() has already been scheduled on
> one CPU and is spinning on the lock, and ipt_ulog_packet() flushes the
> queue on another CPU by calling ulog_send() right before it exits,
> there will be no skbuff when ulog_timer() acquires the lock and calls
> ulog_send(). Cancelling the timer in ulog_send() doesn't help because
> it has already been scheduled and is running on the first CPU.
>
> Similar problem exists in ebt_ulog.c and nfnetlink_log.c.
Applied, thanks Mark.
prev parent reply other threads:[~2006-08-11 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 16:31 [PATCH] Fix ipt_ULOG panics on SMP kernels Mark Huang
2006-08-11 16:19 ` Patrick McHardy
2006-08-11 16:45 ` Mark Huang
2006-08-11 17:13 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44DCBABA.4090207@trash.net \
--to=kaber@trash.net \
--cc=mlhuang@CS.Princeton.EDU \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.