From: Joshua Brindle <jbrindle@tresys.com>
To: James Morris <jmorris@namei.org>
Cc: selinux@tycho.nsa.gov
Subject: Re: [PATCH] fixfiles: fix test for $LOGFILE
Date: Sat, 12 Aug 2006 10:22:18 -0400 [thread overview]
Message-ID: <44DDE41A.3080600@tresys.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0608121008560.14758@d.namei>
James Morris wrote:
> Please apply.
>
> ---
>
> --- fixfiles.orig 2006-08-12 00:52:22.000000000 -0400
> +++ fixfiles 2006-08-12 10:07:30.000000000 -0400
> @@ -48,7 +48,7 @@
> # Log to either syslog or a LOGFILE
> #
> logit () {
> -if [ -z $LOGFILE ]; then
> +if [ ! -z $LOGFILE ]; then
> echo $1 >> $LOGFILE
> fi
> }
>
Why not if [ -n $LOGFILE ]; then ?
From man bash:
-z string
True if the length of string is zero.
string
-n string
True if the length of string is non-zero.
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
prev parent reply other threads:[~2006-08-12 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-12 14:09 [PATCH] fixfiles: fix test for $LOGFILE James Morris
2006-08-12 14:22 ` Joshua Brindle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44DDE41A.3080600@tresys.com \
--to=jbrindle@tresys.com \
--cc=jmorris@namei.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.