From: Jeff Garzik <jeff@garzik.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>,
"David S. Miller" <davem@redhat.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] cleanup of the NETIF_F_* flag definitions
Date: Sat, 12 Aug 2006 15:37:32 -0400 [thread overview]
Message-ID: <44DE2DFC.5030902@garzik.org> (raw)
In-Reply-To: <1155410647.13508.119.camel@lappy>
Peter Zijlstra wrote:
> Cleanup the NETIF_F_ flag definitions
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
If you are going to do a cleanup here, you should use the form that
makes it _immediately_ obvious which bit(s) are being used:
#define NETIF_F_SG (1 << 0)
#define NETIF_F_IP_CSUM (1 << 1)
#define NETIF_F_NO_CSUM (1 << 2)
[...]
Maybe DaveM's brain automatically translates all hex numbers into bit
numbers, but not everybody's brain works that way... :) It is better to
use a form that requires no human brain translation...
Jeff
next prev parent reply other threads:[~2006-08-12 19:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-12 19:24 [PATCH] cleanup of the NETIF_F_* flag definitions Peter Zijlstra
2006-08-12 19:37 ` Jeff Garzik [this message]
2006-08-13 13:06 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44DE2DFC.5030902@garzik.org \
--to=jeff@garzik.org \
--cc=a.p.zijlstra@chello.nl \
--cc=davem@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.