Re: priv_data patch

[Patrick McHardy <kaber@trash.net>]

Joakim Axelsson wrote:
> 2006-08-14 17:28:19+0200, Patrick McHardy <kaber@trash.net> ->
> 
>>>
>>>Please have a look here for 4 modules "needing" this patch:
>>>http://www.gozem.se/~gozem/netfilter/
>>
>>Please post your examples to the list.
>>
> 
> 
> In which format? As a full patch for the kernel or something that fits in
> pom-ng? The current code works for 2.4 and early 2.6. I don't want to spend
> time porting it into "wrong" API now when we are discussing priv_data to be
> or not to be :-)

I'm mostly interested in the way you wish to use it, so I can better
judge whether this change is worth doing or not.

> Yes, its ugly but has been working in our routers for atleast a year now. I
> will however port it to use a global list state instead as some of the
> modules already does.

I don't say its not working, but we can't put something like this
in the kernel. So you need some identifier to find your state after
changes. Besides the uglyness, we don't have anywhere to put it in
the blob so userspace can return it, so it would end up beeing something
local to the individual modules again (like table name in recent
and hashlimit), just what we're doing today.