All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Brice Goglin <brice@myri.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] myri10ge: allow to disable link status change reporting
Date: Mon, 14 Aug 2006 18:02:30 -0400	[thread overview]
Message-ID: <44E0F2F6.7020403@garzik.org> (raw)
In-Reply-To: <44E0F0C1.8000408@myri.com>

Brice Goglin wrote:
> Add myri10ge_verbose module parameter to disable reporting of
> link status change since some Ethernet switches seem to generate
> a lot of status changes under some circumstances and some people
> want to avoid useless flooding in the logs.
> 
> Also add a counter for link status changes to statistics.
> 
> Signed-off-by: Brice Goglin <brice@myri.com>

NAK - use the standard netif_msg_xxx and the msg_enable style variable 
found in many drivers.  No need for a module parameter, ethtool already 
covers this type of need.

	Jeff




  reply	other threads:[~2006-08-14 22:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <44E0DA08.9080304@myri.com>
2006-08-14 21:52 ` [PATCH 1/3] myri10ge: define some previously hardwired firmware constants Brice Goglin
2006-08-14 21:53 ` [PATCH 2/3] myri10ge: allow to disable link status change reporting Brice Goglin
2006-08-14 22:02   ` Jeff Garzik [this message]
2006-08-15 12:46     ` Brice Goglin
2006-08-15 12:49       ` Brice Goglin
2006-08-14 21:53 ` [PATCH 3/3] myri10ge: convert to netdev_alloc_skb Brice Goglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44E0F2F6.7020403@garzik.org \
    --to=jeff@garzik.org \
    --cc=brice@myri.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.