All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Hagen <sebastian_hagen@memespace.net>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: libnetfilter_conntrack checks for (getuid() == 0)
Date: Tue, 15 Aug 2006 19:45:20 +0200	[thread overview]
Message-ID: <44E20830.6090402@memespace.net> (raw)
In-Reply-To: <44E20094.8080309@trash.net>

[-- Attachment #1: Type: text/plain, Size: 96 bytes --]

Patrick McHardy wrote:
> Please send a patch.
Done, and attached to this mail.

Sebastian Hagen

[-- Attachment #2: libnetfilter_conntrack_getuid.patch --]
[-- Type: text/x-patch, Size: 784 bytes --]

--- libnetfilter_conntrack/src/libnetfilter_conntrack.c	2006-05-24 19:39:29.000000000 +0200
+++ libnetfilter_conntrack_patched/src/libnetfilter_conntrack.c	2006-08-15 19:41:25.000000000 +0200
@@ -1125,12 +1125,6 @@
 
 int nfct_event_conntrack(struct nfct_handle *cth)
 {
-	/*
-	 * You need to be root to listen to conntrack events
-	 */
-	if (getuid() != 0)
-		return -EPERM;
-	
 	cth->handler = nfct_conntrack_netlink_handler;
 	return nfnl_listen(cth->nfnlh, &callback_handler, cth);
 }
@@ -1298,12 +1292,6 @@
 
 int nfct_event_expectation(struct nfct_handle *cth)
 {
-	/*
-	 * You need to be root to listen to conntrack events
-	 */
-	if (getuid() != 0)
-		return -EPERM;
-
 	cth->handler = nfct_expect_netlink_handler;
 	return nfnl_listen(cth->nfnlh, &callback_handler, cth);
 }

  reply	other threads:[~2006-08-15 17:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-15 17:10 libnetfilter_conntrack checks for (getuid() == 0) Sebastian Hagen
2006-08-15 17:12 ` Patrick McHardy
2006-08-15 17:45   ` Sebastian Hagen [this message]
2006-08-16 11:12     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44E20830.6090402@memespace.net \
    --to=sebastian_hagen@memespace.net \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.