Re: [PATCH] Boyer Moore textsearch bug fix

[Pablo Neira Ayuso <pablo@netfilter.org>]

Patrick McHardy wrote:
> Michael Rash wrote:
> 
>>--- linux-2.6.17.8/lib/ts_bm.c.orig	2006-08-16 21:17:38.000000000 -0400
>>+++ linux-2.6.17.8/lib/ts_bm.c	2006-08-16 21:17:56.000000000 -0400
>>@@ -151,8 +151,8 @@
>> 	bm = ts_config_priv(conf);
>> 	bm->patlen = len;
>> 	bm->pattern = (u8 *) bm->good_shift + prefix_tbl_len;
>>-	compute_prefix_tbl(bm, pattern, len);
>> 	memcpy(bm->pattern, pattern, len);
>>+	compute_prefix_tbl(bm, pattern, len);
> 
> 
> 
> Good catch, thanks. But since both pattern and len are also passed
> to compute_prefix_tbl as arguments, I think we should either make
> it use only those arguments, or remove those arguments and use only
> the values from struct ts_bm.

Damn, that is my fault, thanks for the catch Michael.

> Please send a new patch and add a Signed-off-by line so I can
> apply it. Thanks.

Patrick, do you plan to pass this patch to -stable as well?

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of 
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris