From: Jeff Garzik <jgarzik@pobox.com>
To: Jesse Huang <jesse@icplus.com.tw>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH 1/6] IP100A, add end of pci id table
Date: Thu, 17 Aug 2006 10:45:14 -0400 [thread overview]
Message-ID: <44E480FA.70806@pobox.com> (raw)
In-Reply-To: <1155841247.4532.6.camel@localhost.localdomain>
Jesse Huang wrote:
> @@ -212,7 +212,7 @@ static const struct pci_device_id sundan
> { 0x1186, 0x1002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 4 },
> { 0x13F0, 0x0201, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 5 },
> { 0x13F0, 0x0200, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 6 },
> - { }
> + { 0,}
> };
> MODULE_DEVICE_TABLE(pci, sundance_pci_tbl);
>
> @@ -231,7 +231,7 @@ static const struct pci_id_info pci_id_t
> {"D-Link DL10050-based FAST Ethernet Adapter"},
> {"Sundance Technology Alta"},
> {"IC Plus Corporation IP100A FAST Ethernet Adapter"},
> - { } /* terminate list. */
> + { NULL,} /* terminate list. */
NAK.
An empty array element "{ }" implies NULL. It is the kernel standard to
prefer "{ }" over an explicit initialization. Looks cleaner.
Jeff
next prev parent reply other threads:[~2006-08-17 14:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-17 19:00 [PATCH 1/6] IP100A, add end of pci id table Jesse Huang
2006-08-17 14:45 ` Jeff Garzik [this message]
2006-08-18 5:52 ` Jesse Huang
2006-08-18 11:09 ` Jeff Garzik
2006-08-21 3:28 ` Jesse Huang
2006-08-17 15:19 ` Alexey Dobriyan
2006-08-18 6:15 ` Jesse Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44E480FA.70806@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=jesse@icplus.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.