Re: connectathon special test failure in recent kernels

[Steve Dickson <SteveD@redhat.com>]

Chuck Lever wrote:
> On 8/8/06, Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> 
>>On Tue, 2006-08-08 at 15:20 -0400, Chuck Lever wrote:
>>
>>>Is the connectathon holey test failure going to be fixed before 2.6.18
>>>is finalized?
>>
>>Depends. Have you traced it in order to figure out what is wrong?
> 
> 
> Ah.  Bruce reported this problem a while back, and said that it goes
> away if one of your recent patches to fs/nfs/read.c is reverted.
> Bruce?
Well the patch in question is:

commit 1de3fc12ea085690547a54b6efa01c7348f1cebd
tree ea865786120cfcefac563c54693fef8d3d718f10
parent 128e6ced247cda88f96fa9f2e4ba8b2c4a681560
author Trond Myklebust <Trond.Myklebust@netapp.com> Thu, 25 May 2006
09:40:44 -0400
committer Trond Myklebust <Trond.Myklebust@netapp.com> Fri, 09 Jun 2006
17:34:03 -0400

NFS: Clean up and fix page zeroing when we have short reads

The code that is supposed to zero the uninitialised partial pages when
the server returns a short read is currently broken: it looks at the
nfs_page wb_pgbase and wb_bytes fields instead of the equivalent
nfs_read_data values when deciding where to start truncating the page.

Also ensure that we are more careful about setting PG_uptodate
before retrying a short read: the retry will change the nfs_read_data
args.pgbase and args.count.

I'm looking into now... but this patch definitely breaks the holy
test...

steved.


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs