From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: is_initial_xendomain() Date: Fri, 18 Aug 2006 10:09:32 +0200 Message-ID: <44E575BC.5080502@suse.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Pratt Cc: xen-devel@lists.xensource.com, Jan Beulich List-Id: xen-devel@lists.xenproject.org Ian Pratt wrote: >> #ifdef CONFIG_XEN_PRIVILEGED_GUEST >> #define is_initial_xendomain() (xen_start_info->flags & > SIF_INITDOMAIN) >> #else >> #define is_initial_xendomain() 0 >> #endif >> >> If that is acceptable, I'm ready to create a respective patch >> (but I'd like to avoid spending time on it if there are objections). > > Personally, I'd like to see CONFIG_XEN_PRIVILEGED_GUEST disappear > altogether. The code size saving is small, and most people use the -xen > kernel rather than -xen0/-xenU anyway. For development it's handy to have a separate xenU kernel, for both build time and size. Most size savings come from dropping all the drivers though, not CONFIG_XEN_PRIVILEGED_GUEST. And gcc should be clever enougth to optimize away "if (0) { code block }", so you get the size savings even with CONFIG_XEN_PRIVILEGED_GUEST being hidden in some header file as listed above. cheers, Gerd -- Gerd Hoffmann http://www.suse.de/~kraxel/julika-dora.jpeg