All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: xen-devel@lists.xensource.com
Subject: is_initial_xendomain()
Date: Fri, 18 Aug 2006 09:12:00 +0200	[thread overview]
Message-ID: <44E58460.76E4.0078.0@novell.com> (raw)

Seeing many cases of uses like

#ifdef CONFIG_XEN_PRIVILEGED_GUEST
	if (is_initial_xendomain()) {
		...
	}
#endif

I'm wondering if it wasn't nice to eliminate the preprocessor
conditionals (which appear to be there only to cut down on
code size) by doing the conditional in a single place instead:

#ifdef CONFIG_XEN_PRIVILEGED_GUEST
#define is_initial_xendomain() (xen_start_info->flags & SIF_INITDOMAIN)
#else
#define is_initial_xendomain() 0
#endif

If that is acceptable, I'm ready to create a respective patch
(but I'd like to avoid spending time on it if there are objections).

Jan

             reply	other threads:[~2006-08-18  7:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-18  7:12 Jan Beulich [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-08-18  7:56 is_initial_xendomain() Ian Pratt
2006-08-18  8:09 ` is_initial_xendomain() Gerd Hoffmann
2006-08-18  8:57 ` is_initial_xendomain() Keir Fraser
2006-08-18 12:15   ` is_initial_xendomain() Jan Beulich
2006-08-22 10:35     ` is_initial_xendomain() Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44E58460.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.