From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mtagate6.de.ibm.com (mtagate6.de.ibm.com [195.212.29.155]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mtagate6.de.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTP id DD2EB67B73 for ; Fri, 18 Aug 2006 23:25:16 +1000 (EST) Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.7/8.13.7) with ESMTP id k7IDPCBA075034 for ; Fri, 18 Aug 2006 13:25:12 GMT Received: from d12av04.megacenter.de.ibm.com (d12av04.megacenter.de.ibm.com [9.149.165.229]) by d12nrmr1607.megacenter.de.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id k7IDT6sd107280 for ; Fri, 18 Aug 2006 15:29:06 +0200 Received: from d12av04.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av04.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id k7IDPBCl004548 for ; Fri, 18 Aug 2006 15:25:12 +0200 Message-ID: <44E5BFB7.4000400@de.ibm.com> Date: Fri, 18 Aug 2006 15:25:11 +0200 From: Thomas Klein MIME-Version: 1.0 To: Arjan van de Ven Subject: Re: [2.6.19 PATCH 3/7] ehea: queue management References: <200608181331.19501.ossthema@de.ibm.com> <1155903451.4494.168.camel@laptopd505.fenrus.org> In-Reply-To: <1155903451.4494.168.camel@laptopd505.fenrus.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Thomas Klein , Jan-Bernd Themann , netdev , linux-kernel , Christoph Raisch , linux-ppc , Marcus Eder List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Arjan van de Ven wrote: >> + queue->queue_length = nr_of_pages * pagesize; >> + queue->queue_pages = vmalloc(nr_of_pages * sizeof(void *)); > > > wow... is this really so large that it warrants a vmalloc()??? Agreed: Replaced with kmalloc() Regards Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751384AbWHRNZQ (ORCPT ); Fri, 18 Aug 2006 09:25:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751387AbWHRNZQ (ORCPT ); Fri, 18 Aug 2006 09:25:16 -0400 Received: from mtagate2.de.ibm.com ([195.212.29.151]:27599 "EHLO mtagate2.de.ibm.com") by vger.kernel.org with ESMTP id S1751384AbWHRNZO (ORCPT ); Fri, 18 Aug 2006 09:25:14 -0400 Message-ID: <44E5BFB7.4000400@de.ibm.com> Date: Fri, 18 Aug 2006 15:25:11 +0200 From: Thomas Klein User-Agent: Thunderbird 1.5 (X11/20051201) MIME-Version: 1.0 To: Arjan van de Ven CC: Jan-Bernd Themann , netdev , Christoph Raisch , Jan-Bernd Themann , linux-kernel , linux-ppc , Marcus Eder , Thomas Klein Subject: Re: [2.6.19 PATCH 3/7] ehea: queue management References: <200608181331.19501.ossthema@de.ibm.com> <1155903451.4494.168.camel@laptopd505.fenrus.org> In-Reply-To: <1155903451.4494.168.camel@laptopd505.fenrus.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Arjan van de Ven wrote: >> + queue->queue_length = nr_of_pages * pagesize; >> + queue->queue_pages = vmalloc(nr_of_pages * sizeof(void *)); > > > wow... is this really so large that it warrants a vmalloc()??? Agreed: Replaced with kmalloc() Regards Thomas