All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Amin Azez <azez@ufomechanic.net>
Cc: Jesper Dangaard Brouer <hawk@diku.dk>,
	netfilter-devel@lists.netfilter.org
Subject: Re: ipt_vlan
Date: Fri, 18 Aug 2006 20:18:03 +0200	[thread overview]
Message-ID: <44E6045B.6050407@trash.net> (raw)
In-Reply-To: <44E5C6E2.30809@ufomechanic.net>

Amin Azez wrote:
> Attached is my ipt_vlan patch for 2.6.17 and 2.6.11, and the iptables
> patch to go with it. It's based on the mac match.

This looks useful. If we hadn't already got ebt_vlan (which seems
to do the same thing with a few extra features) I would be tempted
to ask you to submit it :)

> I think the iptables patch is wrong, the way I freak the extension
> makefile needs reviewing, but it does compile.

> --- extensions/Makefile.orig    2006-06-30 10:41:38.000000000 +0100
> +++ extensions/Makefile 2006-06-30 10:42:00.000000000 +0100
> @@ -14,2 +14,4 @@
> 
> +PF_EXT_SLIB+=vlan
> +

Its fine this way, although the usual way for extensions is to either
add them to the long list at the top or add a .test script.

      reply	other threads:[~2006-08-18 18:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-17 16:28 lots of oopses Amin Azez
2006-08-17 17:04 ` Patrick McHardy
2006-08-18  7:33   ` Amin Azez
2006-08-18 18:23     ` Patrick McHardy
     [not found]       ` <44E6C247.9010704@ufomechanic.net>
2006-08-21 23:09         ` Patrick McHardy
2006-08-18 13:55   ` ipt_vlan Amin Azez
2006-08-18 18:18     ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44E6045B.6050407@trash.net \
    --to=kaber@trash.net \
    --cc=azez@ufomechanic.net \
    --cc=hawk@diku.dk \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.