Re: [PATCH] Asus P5P800-VM, S/PDIF indication wrong?

[Magnus Sandin <magnus@sandin.cx>]

I can confirm that that approach works as well!

Will this patch go into 1.0.12?

Regards
// Magnus Sandin

Takashi Iwai wrote:
> At Mon, 21 Aug 2006 22:11:29 +0200,
> Magnus Sandin wrote:
>   
>> Hello!
>>
>> The attached patch will force building the S/PDIF controls on the PCU
>> SSID for Asus P5P800-VM motherboard, even if the  AC97_EI_SPDIF bit is
>> not set.
>>
>> Is this approach OK or do you guys want to have the check somewhere else?
>>
>> Signed-off-by: Magnus Sandin (magnus@sandin.cx)
>>     
>
> I prefer the one like below.  Could you check whether it works?
>
>
> Takashi
>
> diff -r 2359af36395e pci/ac97/ac97_codec.c
> --- a/pci/ac97/ac97_codec.c	Tue Aug 22 13:16:39 2006 +0200
> +++ b/pci/ac97/ac97_codec.c	Tue Aug 22 13:21:01 2006 +0200
> @@ -1573,6 +1573,12 @@ static int snd_ac97_mixer_build(struct s
>  	}
>  
>  	/* build S/PDIF controls */
> +
> +	/* Hack for ASUS P5P800-VM, which does not indicate S/PDIF capability */
> +	if (ac97->subsystem_vendor == 0x1043 &&
> +	    ac97->subsystem_device == 0x810f)
> +		ac97->ext_id |= AC97_EI_SPDIF;
> +
>  	if ((ac97->ext_id & AC97_EI_SPDIF) && !(ac97->scaps & AC97_SCAP_NO_SPDIF)) {
>  		if (ac97->build_ops->build_spdif) {
>  			if ((err = ac97->build_ops->build_spdif(ac97)) < 0)
>   

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642