From: Richard Knutsson <ricknu-0@student.ltu.se>
To: Andrew Morton <akpm@osdl.org>
Cc: Prajakta Gudadhe <pgudadhe@nvidia.com>,
jeff@garzik.org, linux-kernel@vger.kernel.org
Subject: Generic booleans in -mm (was: Re: [PATCH] Sgpio support in sata_nv)
Date: Wed, 23 Aug 2006 00:54:34 +0200 [thread overview]
Message-ID: <44EB8B2A.8030603@student.ltu.se> (raw)
In-Reply-To: <20060821224457.65de5111.akpm@osdl.org>
Andrew Morton wrote:
>On Mon, 21 Aug 2006 18:17:06 -0700
>Prajakta Gudadhe <pgudadhe@nvidia.com> wrote:
>
>
[snip]
>>...
>>
>>+
>>+static bool nv_sgpio_update_led(struct nv_sgpio_led *led, bool *on_off)
>>
>>
>
>Please remove the new private implementation of `bool' and just use `int'.
>There's ongoing discussion about how to do a kernel-wide implementation of
>bool, and adding new driver-private ones now just complicates that.
>
>
Well, the discussion seem to have quiet down (so time to start it up
again ;) ). But would you take a patch for a generic implementation of
bool/false/true? I sent one 29th of July with no complaints or
suggestions. I am happy to send it again.
About this patch, isn't better to leave the 'bool'-type if there is a
will to make a common boolean? Easier to find and convert a local
definition of bool then finding functions who are boolean, but decleard
as some kind of integer.
Just a thought
/Richard Knutsson
next prev parent reply other threads:[~2006-08-22 22:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-22 1:17 [PATCH] Sgpio support in sata_nv Prajakta Gudadhe
2006-08-22 5:44 ` Andrew Morton
2006-08-22 22:54 ` Richard Knutsson [this message]
2006-08-22 23:17 ` Generic booleans in -mm (was: Re: [PATCH] Sgpio support in sata_nv) Andrew Morton
2006-08-23 11:14 ` [PATCH 2.6.18-rc4-mm2] Generic boolean (was: Re: Generic booleans in -mm) Richard Knutsson
2006-08-23 12:06 ` Jan Engelhardt
2006-08-24 4:06 ` [PATCH 2.6.18-rc4-mm2] Generic boolean Richard Knutsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44EB8B2A.8030603@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pgudadhe@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.