From: Zang Roy-r61911 <tie-fei.zang@freescale.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
Yang Xin-Xin-r48390 <Xin-Xin.Yang@freescale.com>
Subject: Re: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver
Date: Wed, 23 Aug 2006 16:45:21 +0800 [thread overview]
Message-ID: <44EC15A1.4090807@freescale.com> (raw)
In-Reply-To: <1156304163.8433.19.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
> On Wed, 2006-08-23 at 10:20 +0800, Zang Roy-r61911 wrote:
>
>> The patch passes the UPIO_TSI flag to general 8259 serial driver
>>
>
> Patch looks damaged to me... appart from that, what it does looks ok to
> me.
Sorry. It seems imported by my mail client. Please pick up the following
one.
Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
---
arch/powerpc/kernel/legacy_serial.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/legacy_serial.c
b/arch/powerpc/kernel/legacy_serial.c
index 359ab89..07c2c00 100644
--- a/arch/powerpc/kernel/legacy_serial.c
+++ b/arch/powerpc/kernel/legacy_serial.c
@@ -115,6 +115,7 @@ static int __init add_legacy_soc_port(st
u64 addr;
u32 *addrp;
upf_t flags = UPF_BOOT_AUTOCONF | UPF_SKIP_TEST | UPF_SHARE_IRQ;
+ struct device_node *tsi = of_get_parent(np);
/* We only support ports that have a clock frequency properly
* encoded in the device-tree.
@@ -134,7 +135,10 @@ static int __init add_legacy_soc_port(st
/* Add port, irq will be dealt with later. We passed a translated
* IO port value. It will be fixed up later along with the irq
*/
- return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ, flags, 0);
+ if (tsi && !strcmp(tsi->type, "tsi-bridge"))
+ return add_legacy_port(np, -1, UPIO_TSI, addr, addr, NO_IRQ,
flags, 0);
+ else
+ return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ,
flags, 0);
}
static int __init add_legacy_isa_port(struct device_node *np,
@@ -464,7 +468,7 @@ static int __init serial_dev_init(void)
fixup_port_irq(i, np, port);
if (port->iotype == UPIO_PORT)
fixup_port_pio(i, np, port);
- if (port->iotype == UPIO_MEM)
+ if ((port->iotype == UPIO_MEM) || (port->iotype == UPIO_TSI))
fixup_port_mmio(i, np, port);
}
--
1.4.0
next prev parent reply other threads:[~2006-08-23 8:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-23 2:20 [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver Zang Roy-r61911
2006-08-23 3:36 ` Benjamin Herrenschmidt
2006-08-23 8:45 ` Zang Roy-r61911 [this message]
2006-08-23 13:08 ` Paul Mackerras
2006-08-23 21:52 ` Benjamin Herrenschmidt
2006-08-24 4:43 ` Zang Roy-r61911
2006-08-24 5:17 ` Benjamin Herrenschmidt
2006-08-24 5:38 ` Zang Roy-r61911
2006-08-24 5:49 ` Li Yang-r58472
2006-08-24 5:54 ` Zang Roy-r61911
2006-08-23 4:30 ` Kumar Gala
2006-08-23 6:13 ` Paul Mackerras
2006-08-23 6:27 ` Zang Roy-r61911
2006-08-23 7:08 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44EC15A1.4090807@freescale.com \
--to=tie-fei.zang@freescale.com \
--cc=Xin-Xin.Yang@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.