From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH 6/7, RFC] x86_64: basic changes for supporting compatibility mode guest Date: Wed, 23 Aug 2006 13:44:06 +0200 Message-ID: <44EC3F86.9000409@suse.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com, Jan Beulich List-Id: xen-devel@lists.xenproject.org Hi, > If we do 32-bit dom0 kernel then the tools will pick up the 32-bit version > of that structure. So this is only an issue for userspace if we want 64-bit > dom0 to be able to build 32-bit domU's. I suppose this would be nice to > have. I think we certainly want to have that. I'd suggest to have a look at my kexec bits: http://www.suse.de/~kraxel/xen/kexec.html http://www.suse.de/~kraxel/patches/ They include a largely rewritten domain builder, adding support for loading both 32bit and 64bit kernels with the 64bit tools should be easy. > Obvious thing to do is suffix all the structs and defns in arch-x86_foo.h > with _32 or _64 as appropriate. Then, at the end of the header, we define > the non-suffixed versions only if defined(__i386__) or __defined__(x86_64) > (as appropriate). I'd suggest to suffix them with $arch instead, so we have the option to handle even ia64 on x86 machines. cheers, Gerd -- Gerd Hoffmann http://www.suse.de/~kraxel/julika-dora.jpeg