All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: "Wolstenholme, Daniel E" <daniel.e.wolstenholme@intel.com>
Cc: Jeremy Higdon <jeremy@sgi.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] Add MSI support to sata_vsc driver
Date: Thu, 24 Aug 2006 02:56:15 -0400	[thread overview]
Message-ID: <44ED4D8F.9070600@garzik.org> (raw)
In-Reply-To: <87840E8EE8A8D240A13F8AA92CAB07D9024C14BF@azsmsx402>

two issues remain:

1) matching pci_disable_msi() is missing

2) as I mentioned previously, do not explicitly initialize irq_flags to 
zero, they are already zero via memset(3).  Only initialize irq_flags 
for the case where pci_enable_msi() fails.



  reply	other threads:[~2006-08-24  6:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-23 23:17 [PATCH] Add MSI support to sata_vsc driver Wolstenholme, Daniel E
2006-08-24  6:56 ` Jeff Garzik [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-09-01 20:11 Wolstenholme, Daniel E
2006-08-25  0:58 Wolstenholme, Daniel E
2006-08-24 20:55 Wolstenholme, Daniel E
2006-08-17 21:28 Wolstenholme, Daniel E
2006-08-17 23:44 ` Jeff Garzik
2006-08-18  0:18   ` Jeremy Higdon
     [not found] <87840E8EE8A8D240A13F8AA92CAB07D9024C14A6@azsmsx402>
2006-08-17  4:07 ` Jeremy Higdon
2006-08-17 12:30   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44ED4D8F.9070600@garzik.org \
    --to=jeff@garzik.org \
    --cc=daniel.e.wolstenholme@intel.com \
    --cc=jeremy@sgi.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.