From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Masover Subject: Re: Reiser4 und LZO compression Date: Sun, 27 Aug 2006 04:42:59 -0500 Message-ID: <44F16923.9050609@slaphack.com> References: <20060827003426.GB5204@martell.zuzino.mipt.ru> <20060827010428.5c9d943b.akpm@osdl.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: list-help: list-unsubscribe: list-post: Errors-To: flx@namesys.com In-Reply-To: <20060827010428.5c9d943b.akpm@osdl.org> List-Id: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Andrew Morton Cc: Alexey Dobriyan , reiserfs-list@namesys.com, linux-kernel@vger.kernel.org Andrew Morton wrote: > On Sun, 27 Aug 2006 04:34:26 +0400 > Alexey Dobriyan wrote: > >> The patch below is so-called reiser4 LZO compression plugin as extracted >> from 2.6.18-rc4-mm3. >> >> I think it is an unauditable piece of shit and thus should not enter >> mainline. > > Like lib/inflate.c (and this new code should arguably be in lib/). > > The problem is that if we clean this up, we've diverged very much from the > upstream implementation. So taking in fixes and features from upstream > becomes harder and more error-prone. Well, what kinds of changes have to happen? I doubt upstream would care about moving some of it to lib/ -- and anyway, reiserfs-list is on the CC. We are speaking of upstream in the third party in the presence of upstream, so... Maybe just ask upstream?