From: llandre <r&d2@dave-tech.it>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] DS1374 watchdog capabilities
Date: Mon, 28 Aug 2006 13:13:06 +0200 [thread overview]
Message-ID: <44F2CFC2.3070705@dave-tech.it> (raw)
In-Reply-To: <20060828110201.4F3CC3525AB@atlas.denx.de>
>> I'd like to use DS1374 watchdog capabilities. Is it correct to put the
>> new stuff in the existing RTC driver (rtc/ds1374.c)? I was thinking
>
> I don't like this idea. Nobody will search there when looking for
> watchdog code.
I see.
> How much of such "new stuff" code will be needed? I guess it's just
> some intialization, and eventually the trigger routine?
Yes, something like that.
>> If it is not acceptable, where should I put the new stuff?
>
> drivers/watchdog/ds1374.c ?
Ok.
What about the common stuff (registers definitions for example) in order
to avoid code duplication? Is it ok to add include/ds1374.h and to make
and to make functions rtc_read and rtc_write_raw non-static?
--
llandre
DAVE Electronics System House - R&D Department
web: http://www.dave-tech.it
email: r&d2 at dave-tech.it
next prev parent reply other threads:[~2006-08-28 11:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-28 10:24 [U-Boot-Users] DS1374 watchdog capabilities llandre
2006-08-28 10:30 ` Liu Dave-r63238
2006-08-28 11:02 ` Wolfgang Denk
2006-08-28 11:13 ` llandre [this message]
2006-08-31 11:21 ` llandre
2006-08-31 12:27 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F2CFC2.3070705@dave-tech.it \
--to=r&d2@dave-tech.it \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.