All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Knutsson <ricknu-0@student.ltu.se>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Removed unreachable code and fixed one	compiler
Date: Mon, 28 Aug 2006 18:00:32 +0000	[thread overview]
Message-ID: <44F32F40.1040007@student.ltu.se> (raw)
In-Reply-To: <1156784251.4195.7.camel@localhost.localdomain>

ville palo wrote:

>On Mon, 2006-08-28 at 18:59 +0200, Benoit Boissinot wrote:
>  
>
>>You are removing the comments here, and it is useful information to
>>understand the code.
>>
>>    
>>
>
>Yes, you are right, here's the fixed patch:
>
>
>Signed-off-by: Ville Palo <ville.palo@vi64pa.net>
>
>  
>
<slice>

> 	goto again;
>@@ -1710,11 +1707,8 @@ static int mcdx_tray_move(struct cdrom_d
> 	if (!(stuffp->present & DOOR))
> 		return -ENOSYS;
> 
>-	if (position)		/* 1: eject */
>-		return mcdx_talk(stuffp, "\xf6", 1, NULL, 1, 5 * HZ, 3);
>-	else			/* 0: close */
>-		return mcdx_talk(stuffp, "\xf8", 1, NULL, 1, 5 * HZ, 3);
>-	return 1;
>+	/* If position is 1 then eject, otherwise close */
>+	return mcdx_talk(stuffp, position ? "\xf6" : "\xf8", 1, NULL, 1, 5 * HZ, 3);
> }
> 
>
Not to be picky, but isn't it: "If position is 0 then close, otherwise 
eject"? ;)

Richard Knutsson

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2006-08-28 18:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-28 16:57 [KJ] [PATCH] Removed unreachable code and fixed one compiler warning ville palo
2006-08-28 16:59 ` [KJ] [PATCH] Removed unreachable code and fixed one compiler Benoit Boissinot
2006-08-28 17:26 ` Nishanth Aravamudan
2006-08-28 17:26 ` [KJ] [PATCH] Removed unreachable code and fixed one ville palo
2006-08-28 17:49 ` ville palo
2006-08-28 17:51 ` [KJ] [PATCH] Removed unreachable code and fixed one compiler Nishanth Aravamudan
2006-08-28 18:00 ` Richard Knutsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44F32F40.1040007@student.ltu.se \
    --to=ricknu-0@student.ltu.se \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.