From: Henne <henne@nachtwindheim.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] pci_module_init to pci_module_register
Date: Tue, 29 Aug 2006 08:23:48 +0000 [thread overview]
Message-ID: <44F3F994.2010203@nachtwindheim.de> (raw)
In-Reply-To: <d16b1c80608290058q78286131r93d63f0e8c3d1398@mail.gmail.com>
>
> TODO:
> - convert from pci_module_init to pci_register_driver
> - don't do it for drivers that are 2.4 compatible
>
> I have found 98 occurrences of the use of pci_module_init in 2.6.18-rc4.
>
In 2.6.18-rc4-mm3 there are only 11 left, since 2 big patches for netdev and scsi
were merged, so pci_module_init() will surely die out in the next releases.
The date is set to Jan07, but there are still new 2.6 drivers which use it.
> I would like to know what it means by "don't do it for drivers that
> are 2.4 compatible"?
>
> The drivers are in 2.6 Linux kernel, so they are meant for 2.6 alone.
> So, as long as the change is in the drivers in 2.6 code base, it
> shouldn't matter for 2.4, right? or am I missing something here?
>
>
I think that driver maintainers don't want to keep an eye on 2 drivers which become more and more different.
So the driver gets some ifdefs to work on both, 2.4 and 2.[56].
But now since 2.4 takes no new features and is __just__ bugfixing the development of these drivers
stands still in 2.4-tree.
And after the change of the IRQ-flags namespace change the 2.6-drivers the compatibility is definitively broken.
Thats imho the reason to break this and make the drivers __fit-2.6-only__.
But thats just my opinion.
Greets,
Henne
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2006-08-29 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-29 8:10 [KJ] pci_module_init to pci_module_register Shakthi Kannan
2006-08-29 8:23 ` Henne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F3F994.2010203@nachtwindheim.de \
--to=henne@nachtwindheim.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.