All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Courtier-Dutton <James@superbug.co.uk>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@lists.sourceforge.net,
	Thierry Vignaud <tvignaud@mandriva.com>
Subject: Re: [Openchrome-users] via epia boards sound quality
Date: Tue, 29 Aug 2006 13:17:26 +0100	[thread overview]
Message-ID: <44F43056.4080006@superbug.co.uk> (raw)
In-Reply-To: <s5hfyfg7w2c.wl%tiwai@suse.de>

Takashi Iwai wrote:
> At Mon, 28 Aug 2006 16:38:56 +0200,
> Thierry Vignaud wrote:
>   
>> James Courtier-Dutton <James@superbug.co.uk> writes:
>>
>>     
>>> So, with the absence of the VT1617A datasheet, we effectively have
>>> no documentation for that AC97 register touched in your patch.
>>> Could I ask you to raise an alsa bug at
>>> https://bugtrack.alsa-project.org/alsa-bug/
>>>
>>> Enter into the bug everything from your updated email, with the sign
>>> off and attached patch.
>>> I will then check the patch into the HG repository, but I will add a
>>> comment next to it pointing to the bug information. That way, future
>>> developers will know why it has been put there.
>>>       
>> this was added into
>> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2381 but didn't
>> make it into HG (or at least the BR wasn't closed)...
>>     
>
> I committed now.
>
> Thanks,
>
> Takashi
>   

Now that we have the datasheet, it seems that the register you touch 
could cause hardware damage.
 From the datasheet, it disables the headphone amp thermal protection. 
So, this fix could be counter productive. I.e. result in damage to the chip.

I suggest that we only apply it via a module option, so the user then 
knows they are taking a risk by disabling the protection.
If the protection is bogus, i.e. the sensor is faulty, then we need a 
way to detect this faultiness.


James

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

  parent reply	other threads:[~2006-08-29 12:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-20  8:02 [Openchrome-users] via epia boards sound quality Andrey Liakhovets
2006-08-20 12:14 ` James Courtier-Dutton
2006-08-28 14:38   ` Thierry Vignaud
2006-08-28 14:51     ` Takashi Iwai
2006-08-29 11:39       ` James Courtier-Dutton
2006-08-29 11:51         ` Jaroslav Kysela
2006-08-29 12:17       ` James Courtier-Dutton [this message]
2006-08-29 13:23         ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2006-08-20 20:15 Andrey Liakhovets
2006-08-18 21:02 Andrey Liakhovets
2006-08-19 12:24 ` James Courtier-Dutton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44F43056.4080006@superbug.co.uk \
    --to=james@superbug.co.uk \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=tiwai@suse.de \
    --cc=tvignaud@mandriva.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.