From: "Jan Beulich" <jbeulich@novell.com>
To: Jimi Xenidis <jimix@watson.ibm.com>,
Ian Campbell <Ian.Campbell@XenSource.com>
Cc: xen-devel <xen-devel@lists.xensource.com>,
Hollis Blanchard <hollisb@us.ibm.com>,
xen-ppc-devel <xen-ppc-devel@lists.xensource.com>
Subject: Re: [XenPPC] Re: Re: [patch] make ELF functions static
Date: Wed, 30 Aug 2006 12:45:10 +0100 [thread overview]
Message-ID: <44F59666.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C474AC6C-3921-46CB-8C55-16DFCD76B145@watson.ibm.com>
>Ok now that we have established the "compile twice" strategy, then
>why don't we stick them in a new file called elfnote.c and keep them
>global?
Not validly - despite Elf32_Note and Elf64_Note having identical layout
they're distinct structures, and hence for type correctness they should
be compiled twice (and the correct flavor be used) if we don't want to
risk breaking if there ever get additions to these structures defined
that make them different for 32- and 64-bits.
If otoh we don't care about that, then yes, these functions could easily
go in their own file.
Jan
prev parent reply other threads:[~2006-08-30 11:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-29 21:15 [patch] make ELF functions static Hollis Blanchard
2006-08-30 7:03 ` Ian Campbell
2006-08-30 8:38 ` Jan Beulich
2006-08-30 8:44 ` Gerd Hoffmann
2006-08-30 9:06 ` Ian Campbell
2006-08-30 11:00 ` [XenPPC] " Jimi Xenidis
2006-08-30 11:12 ` Gerd Hoffmann
2006-08-30 11:45 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F59666.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=Ian.Campbell@XenSource.com \
--cc=hollisb@us.ibm.com \
--cc=jimix@watson.ibm.com \
--cc=xen-devel@lists.xensource.com \
--cc=xen-ppc-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.