From mboxrd@z Thu Jan  1 00:00:00 1970
From: David F Barrera <dfbp@us.ibm.com>
Subject: Re: [PATCH] [UNTESTED] Fix sentinel in call to execlp
	in	tools/iommu/vnc.c
Date: Wed, 30 Aug 2006 13:20:10 -0500
Message-ID: <44F5D6DA.5090300@us.ibm.com>
References: <44F5B588.4090505@us.ibm.com>
	<1156955488.7718.11.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1156955488.7718.11.camel@localhost.localdomain>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Harry Butterworth <harry@hebutterworth.freeserve.co.uk>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Harry Butterworth wrote:
> This patch should fix your problem here.  I have not tested it.  Please
> give it a go and report whether it is OK to be committed to the tree.
>
> The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the
> sentinel needs to be a 64 bit null pointer for the code to be correct.
>
> Signed-off-by: Harry Butterworth <butterwo@uk.ibm.com>
>  =20
> -----------------------------------------------------------------------=
-
>
> diff -r dc773bf49664 -r 606ec67fb063 tools/ioemu/vnc.c
> --- a/tools/ioemu/vnc.c	Wed Aug 30 10:05:00 2006
> +++ b/tools/ioemu/vnc.c	Wed Aug 30 16:23:38 2006
> @@ -1269,7 +1269,7 @@
>  	exit(1);
> =20
>      case 0:	/* child */
> -	execlp("vncviewer", "vncviewer", s, 0);
> +	execlp("vncviewer", "vncviewer", s, (char *)NULL);
>  	fprintf(stderr, "vncviewer execlp failed\n");
>  	exit(1);
> =20
>  =20
Here's the tail end of what I get:

...
XK_Control_L=E2 undeclared (first use in this function)
/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:847:=20
error: =E2XK_Alt_L=E2 undeclared (first use in this function)
/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864:=20
error: =E2XK_1=E2 undeclared (first use in this function)
/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864:=20
error: =E2XK_9=E2 undeclared (first use in this function)
make[4]: *** [vnc.o] Error 1
make[4]: Leaving directory=20
`/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/i386-dm'
make[3]: *** [subdir-i386-dm] Error 2
make[3]: Leaving directory=20
`/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu'
make[2]: *** [ioemuinstall] Error 2
make[2]: Leaving directory=20
`/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools'
make[1]: *** [install] Error 2
make[1]: Leaving directory=20
`/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools'
make: *** [install-tools] Error 2


--=20

Regards,

David F Barrera
Linux Technology Center
Systems and Technology Group, IBM

"The wisest men follow their own direction. "
=09
                          Euripides