From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Darrick J. Wong" Subject: Re: [PATCH] aic94xx: Increase can_queue and cmds_per_lun Date: Wed, 30 Aug 2006 12:03:16 -0700 Message-ID: <44F5E0F4.5080209@us.ibm.com> References: <44F3CF6E.1070000@us.ibm.com> <1156958383.7701.2.camel@mulgrave.il.steeleye.com> Reply-To: "Darrick J. Wong" Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from e36.co.us.ibm.com ([32.97.110.154]:29843 "EHLO e36.co.us.ibm.com") by vger.kernel.org with ESMTP id S1751319AbWH3TDT (ORCPT ); Wed, 30 Aug 2006 15:03:19 -0400 In-Reply-To: <1156958383.7701.2.camel@mulgrave.il.steeleye.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Linux Kernel Mailing List , linux-scsi@vger.kernel.org, Alexis Bruemmer , Mike Anderson , Konrad Rzeszutek James Bottomley wrote: > This is unnecessary unless you alter it before host alloc (which is > where it takes the shost values from the template). > > Also, I think if you look at the rest of the driver, it's careful to > account for the need for required scbs in its internal queueing > algorithms, so the ASD_FREE_SCBS should be unnecessary. > >> + shost->can_queue = aic94xx_sht.can_queue; Ok then, I think it collapses to this short patch: --D Signed-off-by: Darrick J. Wong diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c index 3e25e31..861d67b 100644 --- a/drivers/scsi/aic94xx/aic94xx_init.c +++ b/drivers/scsi/aic94xx/aic94xx_init.c @@ -623,6 +623,8 @@ static int __devinit asd_pci_probe(struc asd_ha->hw_prof.bios.present ? "build " : "not present", asd_ha->hw_prof.bios.bld); + shost->can_queue = asd_ha->hw_prof.max_scbs; + if (use_msi) pci_enable_msi(asd_ha->pcidev);