From: Steven Rostedt <srostedt@redhat.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com, quintela@redhat.com
Subject: Re: [PATCH] wrong accounting in direct_remap_pfn_range
Date: Wed, 30 Aug 2006 20:37:19 -0400 [thread overview]
Message-ID: <44F62F3F.7030709@redhat.com> (raw)
In-Reply-To: <44F62AA3.7050604@redhat.com>
Steven Rostedt wrote:
> Keir Fraser wrote:
>> I think you're confused.
>
> I usually am :) But not on this one :P
>
grr, I take it back, I am the one that's confused :P
OK, this all happens because this whole blob of code is crazy because it
is missing a "if (size == 0)" check!
The "if (v != u)" is only not true when this function is called with
size == 0, and we don't need to do anything. Why not just have that
check in the beginning and remove the "if (v != u)"?
It would have saved me a lot of wasted time here. Or is this code meant
to confuse me?
Sorry,
-- Steve
next prev parent reply other threads:[~2006-08-31 0:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-29 16:25 [PATCH] wrong accounting in direct_remap_pfn_range Steven Rostedt
2006-08-29 18:22 ` Steven Rostedt
2006-08-30 21:29 ` Keir Fraser
2006-08-31 0:17 ` Steven Rostedt
2006-08-31 0:37 ` Steven Rostedt [this message]
2006-08-31 0:42 ` Keir Fraser
2006-08-31 0:47 ` Steven Rostedt
2006-08-31 1:03 ` Steven Rostedt
2006-08-31 1:05 ` Keir Fraser
2006-08-31 1:35 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F62F3F.7030709@redhat.com \
--to=srostedt@redhat.com \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=quintela@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.