From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: [PATCH] Re: odd vcpu_info accesses in xen/arch/x86/time.c Date: Thu, 31 Aug 2006 10:08:14 +0200 Message-ID: <44F6B50E.76E4.0078.0@novell.com> References: <44F471BA.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 30.08.06 18:27 >>> >On 29/8/06 3:56 pm, "Jan Beulich" wrote: > >> Is there a particular reason why in several places in this file, with a vcpu >> pointer >> at hand, the vcpu_info is accessed through >> >> v->domain->shared_info->vcpu_info[v->vcpu_id] >> >> rather than >> >> v->vcpu_info > >No. They should be fixed. Signed-off-by: Jan Beulich Index: 2006-08-28/xen/arch/x86/time.c =================================================================== --- 2006-08-28.orig/xen/arch/x86/time.c 2006-08-31 09:52:31.000000000 +0200 +++ 2006-08-28/xen/arch/x86/time.c 2006-08-31 09:55:54.000000000 +0200 @@ -676,7 +676,7 @@ static inline void __update_vcpu_system_ struct vcpu_time_info *u; t = &this_cpu(cpu_time); - u = &v->domain->shared_info->vcpu_info[v->vcpu_id].time; + u = &v->vcpu_info->time; version_update_begin(&u->version); @@ -690,7 +690,7 @@ static inline void __update_vcpu_system_ void update_vcpu_system_time(struct vcpu *v) { - if ( v->domain->shared_info->vcpu_info[v->vcpu_id].time.tsc_timestamp != + if ( v->vcpu_info->time.tsc_timestamp != this_cpu(cpu_time).local_tsc_stamp ) __update_vcpu_system_time(v); }