Re: [RFC] Enable/Disable VLAN HW filters

[Ben Greear <greearb@candelatech.com>]

Mitch Williams wrote:
> We've had a few internal requests for a way to enable and disable the
> hardware VLAN filter at runtime.  I'm posting it here for discussion and
> to see if anybody else is interested in this feature.
> 
> Originally I had planned to do this as an Ethtool ioctl, but decided
> instead to handle it through the VLAN module.  Ethtool doesn't know
> anything about VLANs at all.
> 
> There are no userspace changes required to support this functionality.
> 
> To disable HW VLAN filtering:
> # vconfig set_flag <VLAN interface> 2 1
> 
> To enable HW VLAN filtering:
> # vconfig set_flag <VLAN interface> 2 0
> 
> At this point (somewhat obviously), it's only implemented on e1000, but
> this ioctl could be easily implemented by other drivers.

Sounds like a good idea to me.

> +	switch (flag) {
> +	case VLAN_FLAG_REORDER:
> +		if (flag_val)
> +			VLAN_DEV_INFO(dev)->flags |= 1;
> +		else
> +			VLAN_DEV_INFO(dev)->flags &= ~1;
> +		break;

If we're defining constants for the flags, might as well use them here 
instead of using the bare '1'.

Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com