From: Richard Knutsson <ricknu-0@student.ltu.se>
To: Nathan Scott <nathans@sgi.com>
Cc: akpm@osdl.org, xfs-masters@oss.sgi.com, xfs@oss.sgi.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Correcting error-prone boolean-statement
Date: Fri, 01 Sep 2006 03:38:21 +0200 [thread overview]
Message-ID: <44F78F0D.2030907@student.ltu.se> (raw)
In-Reply-To: <20060901111601.R3186664@wobbly.melbourne.sgi.com>
Nathan Scott wrote:
>On Fri, Sep 01, 2006 at 03:18:31AM +0200, Richard Knutsson wrote:
>
>
>>Nathan Scott wrote:
>>
>>
>>>Are you using XFS on your systems? What is your strategy for getting this
>>>runtime tested going to be? Or are you delegating that responsibility? :)
>>>
>>>
>>>
>>Sorry, can't say that I do. So pretty please... ;)
>>Seriously, I can not find a state when this may fail (if not "if (var ==
>>TRUE)" happend to be correct for 'var' != 0 != 1, but that is just a bug
>>waiting to happend).
>>But please correct me if I am wrong.
>>
>>
>
>OK, I'll run with it in my own testing for awhile.
>
Thanks!
> I was also curious to
>why you didn't remove the other few B_TRUE/B_FALSE occurences? (and the
>typedef)?
>
>
Working on it. Should be out tomorrow(or in about 20 hours).
From the "Re: Conversion to generic boolean"-thread (started on
06-08-28), there were those who did not seem to like the conversion. But
since no-one complained about removing "== B_FALSE/B_TRUE", I thought it
best to remove them first and then take the rest from there.
>cheers.
>
>
>
cu
prev parent reply other threads:[~2006-09-01 1:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-31 23:52 [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Correcting error-prone boolean-statement Richard Knutsson
2006-09-01 0:07 ` Nathan Scott
2006-09-01 1:18 ` Richard Knutsson
2006-09-01 1:16 ` Nathan Scott
2006-09-01 1:38 ` Richard Knutsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F78F0D.2030907@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathans@sgi.com \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.