All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: christophe varoqui <christophe.varoqui@free.fr>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: [PATCH] Fixup return code for 'multipath -l'
Date: Fri, 01 Sep 2006 09:36:28 +0200	[thread overview]
Message-ID: <44F7E2FC.1090806@suse.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

Hi Christophe,

'multipath -l' should really set the return code to '0' if no error 
occurred.

Please apply.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

[-- Attachment #2: multipath-tools-fixup-return-code --]
[-- Type: text/plain, Size: 384 bytes --]

 multipath/main.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/multipath/main.c b/multipath/main.c
index c1257a2..b6f8814 100644
--- a/multipath/main.c
+++ b/multipath/main.c
@@ -280,8 +280,10 @@ configure (void)
 
 	filter_pathvec(pathvec, refwwid);
 
-	if (conf->list)
+	if (conf->list) {
+		r = 0;
 		goto out;
+	}
 
 	/*
 	 * core logic entry point

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2006-09-01  7:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-01  7:36 Hannes Reinecke [this message]
2006-09-03 22:39 ` [PATCH] Fixup return code for 'multipath -l' Christophe Varoqui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44F7E2FC.1090806@suse.de \
    --to=hare@suse.de \
    --cc=christophe.varoqui@free.fr \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.