From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Masover Subject: Re: FEATURE Req: integrate badblocks check into fsck.reiser* Date: Fri, 01 Sep 2006 17:27:20 -0500 Message-ID: <44F8B3C8.1050802@slaphack.com> References: <200609012250.44548.vs@namesys.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: list-help: list-unsubscribe: list-post: Errors-To: flx@namesys.com In-Reply-To: <200609012250.44548.vs@namesys.com> List-Id: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: "Vladimir V. Saveliev" Cc: reiserfs-list@namesys.com, Peter Vladimir V. Saveliev wrote: > Hello > > On Friday 01 September 2006 22:23, Peter wrote: >> Perhaps this has been mentioned before. If so, sorry. IMHO, it would be >> useful to integrate a call to badblocks in the fsck/mkfs.reiser* programs >> so that more thorough disk checking can be done at format time. Sort of >> like the option e2fsck -c. If this is added, the output could be fed >> immediately to the reiser format program and badblocks spared prior to >> filesystem use. >> >> JM$0.02 > > both mkfs.reiserfs and fsck.reiserfs have -B option to accept list of bad > blocks. We thought that should be enough. It really should. Why bother with a patch? Just write a wrapper script that runs badblocks and passes in the list to mkfs.