From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hans Reiser <reiser@namesys.com>
Subject: Re: FEATURE Req: integrate badblocks check into fsck.reiser*
Date: Fri, 01 Sep 2006 16:00:20 -0700
Message-ID: <44F8BB84.80603@namesys.com>
References: <ed9tqo$2tc$1@sea.gmane.org> <200609012250.44548.vs@namesys.com> <44F8B3C8.1050802@slaphack.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <reiserfs-list-return-29784-reiserfs=m.gmane.org@namesys.com>
list-help: <mailto:reiserfs-list-help@namesys.com>
list-unsubscribe: <mailto:reiserfs-list-unsubscribe@namesys.com>
list-post: <mailto:reiserfs-list@namesys.com>
Errors-To: flx@namesys.com
In-Reply-To: <44F8B3C8.1050802@slaphack.com>
List-Id: <reiserfs-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: David Masover <ninja@slaphack.com>, ReiserFS List <reiserfs-list@namesys.com>

David Masover wrote:
> Vladimir V. Saveliev wrote:
>> Hello
>>
>> On Friday 01 September 2006 22:23, Peter wrote:
>>> Perhaps this has been mentioned before. If so, sorry. IMHO, it would be
>>> useful to integrate a call to badblocks in the fsck/mkfs.reiser*
>>> programs
>>> so that more thorough disk checking can be done at format time. Sort of
>>> like the option e2fsck -c. If this is added, the output could be fed
>>> immediately to the reiser format program and badblocks spared prior to
>>> filesystem use.
>>>
>>> JM$0.02
>>
>> both mkfs.reiserfs and fsck.reiserfs have -B option to accept list of
>> bad blocks. We thought that should be enough.
>
> It really should.  Why bother with a patch?  Just write a wrapper
> script that runs badblocks and passes in the list to mkfs.
>
>
For average sysadmins, it would be nice to just add a flag and it
happens.  I will take a patch, but I won't write it.;-)