From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Josef Sipek <jsipek@cs.sunysb.edu>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
hch@infradead.org, akpm@osdl.org, viro@ftp.linux.org.uk
Subject: Re: [PATCH 08/22][RFC] Unionfs: Directory manipulation helper functions
Date: Mon, 04 Sep 2006 00:23:14 -0700 [thread overview]
Message-ID: <44FBD462.1040902@goop.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0609040907110.9108@yvahk01.tjqt.qr>
Jan Engelhardt wrote:
>> + if (0 <= bopaque && bopaque < bend)
>>
>
> Turn it. Constant values are usually wanted on the right side.
>
> bopaque >= 0
Not in this case. The test in its current form clearly shows that
bopaque needs to be within a range.
J
--
VGER BF report: H 0
next prev parent reply other threads:[~2006-09-04 7:23 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 1:35 [PATCH 00/22][RFC] Unionfs: Stackable Namespace Unification Filesystem Josef Sipek
2006-09-01 1:37 ` [PATCH 01/22][RFC] Unionfs: Documentation Josef Sipek
2006-09-01 7:42 ` Jan Engelhardt
2006-09-01 1:39 ` [PATCH 02/22][RFC] Unionfs: Kconfig and Makefile Josef Sipek
2006-09-01 12:44 ` Jan Engelhardt
2006-09-01 15:32 ` Randy.Dunlap
2006-09-01 1:40 ` [PATCH 03/22][RFC] Unionfs: Branch management functionality Josef Sipek
2006-09-04 11:20 ` Pekka Enberg
2006-09-01 1:41 ` [PATCH 04/22][RFC] Unionfs: Common file operations Josef Sipek
2006-09-01 12:50 ` Jan Engelhardt
2006-09-01 22:20 ` Trond Myklebust
2006-09-01 22:36 ` Shaya Potter
2006-09-01 22:57 ` Trond Myklebust
2006-09-03 1:03 ` Shaya Potter
2006-09-02 2:47 ` Josef Sipek
2006-09-03 4:10 ` Trond Myklebust
2006-09-01 1:42 ` [PATCH 05/22][RFC] Unionfs: Copyup Functionality Josef Sipek
2006-09-04 6:59 ` Jan Engelhardt
2006-09-04 9:25 ` Josef Sipek
2006-09-04 10:41 ` Jan Engelhardt
2006-09-16 22:13 ` Josef Sipek
2006-09-16 22:26 ` Jan Engelhardt
2006-09-17 1:28 ` Shaya Potter
2006-09-01 1:44 ` [PATCH 06/22][RFC] Unionfs: Dentry operations Josef Sipek
2006-09-04 7:04 ` Jan Engelhardt
2006-09-01 1:45 ` [PATCH 07/22][RFC] Unionfs: Directory file operations Josef Sipek
2006-09-04 7:07 ` Jan Engelhardt
2006-09-01 1:47 ` [PATCH 08/22][RFC] Unionfs: Directory manipulation helper functions Josef Sipek
2006-09-04 7:09 ` Jan Engelhardt
2006-09-04 7:23 ` Jeremy Fitzhardinge [this message]
2006-09-01 1:48 ` [PATCH 09/22][RFC] Unionfs: File operations Josef Sipek
2006-09-01 3:02 ` Ian Kent
2006-09-04 7:11 ` Jan Engelhardt
2006-09-01 1:49 ` [PATCH 10/22][RFC] Unionfs: Inode operations Josef Sipek
2006-09-04 7:18 ` Jan Engelhardt
2006-09-01 1:50 ` [PATCH 11/22][RFC] Unionfs: Lookup helper functions Josef Sipek
2006-09-04 7:24 ` Jan Engelhardt
2006-09-01 1:51 ` [PATCH 12/22][RFC] Unionfs: Main module functions Josef Sipek
2006-09-04 7:28 ` Jan Engelhardt
2006-09-01 1:53 ` [PATCH 00/22][RFC] Unionfs: Stackable Namespace Unification Filesystem Stephen Rothwell
2006-09-01 17:23 ` Josef Sipek
2006-09-03 17:42 ` Jan Engelhardt
2006-09-03 19:44 ` Josef Sipek
2006-09-04 11:01 ` Pekka Enberg
2006-09-04 11:01 ` Pekka Enberg
2006-09-04 23:34 ` Josef Sipek
2006-09-01 1:53 ` [PATCH 13/22][RFC] Unionfs: Readdir state Josef Sipek
2006-09-04 7:30 ` Jan Engelhardt
2006-09-01 1:54 ` [PATCH 14/22][RFC] Unionfs: Rename Josef Sipek
2006-09-01 1:55 ` [PATCH 15/22][RFC] Unionfs: Privileged operations workqueue Josef Sipek
2006-09-04 7:37 ` Jan Engelhardt
2006-09-01 1:56 ` [PATCH 16/22][RFC] Unionfs: Handling of stale inodes Josef Sipek
2006-09-04 7:39 ` Jan Engelhardt
2006-09-01 1:58 ` [PATCH 17/22][RFC] Unionfs: Miscellaneous helper functions Josef Sipek
2006-09-01 1:58 ` [PATCH 18/22][RFC] Unionfs: Superblock operations Josef Sipek
2006-09-04 7:46 ` Jan Engelhardt
2006-09-04 8:24 ` Andreas Schwab
2006-09-04 8:24 ` Andreas Schwab
2006-09-01 1:59 ` [PATCH 19/22][RFC] Unionfs: Helper macros/inlines Josef Sipek
2006-09-04 7:49 ` Jan Engelhardt
2006-09-01 2:01 ` [PATCH 20/22][RFC] Unionfs: Internal include file Josef Sipek
2006-09-04 7:54 ` Jan Engelhardt
2006-09-01 2:01 ` [PATCH 21/22][RFC] Unionfs: Unlink Josef Sipek
2006-09-01 2:02 ` [PATCH 22/22][RFC] Unionfs: Include file Josef Sipek
2006-09-04 7:55 ` Jan Engelhardt
2006-09-03 11:05 ` [PATCH 00/22][RFC] Unionfs: Stackable Namespace Unification Filesystem Pavel Machek
2006-09-04 12:57 ` Jörn Engel
2006-09-05 4:46 ` Al Boldi
2006-09-05 4:46 ` Al Boldi
2006-09-05 7:01 ` Jörn Engel
2006-09-05 7:01 ` Jörn Engel
2006-09-04 13:28 ` Shaya Potter
2006-09-04 20:33 ` Pavel Machek
2006-09-04 21:43 ` Shaya Potter
2006-09-04 23:31 ` Josef Sipek
2006-09-05 6:02 ` Jan Engelhardt
2006-09-05 13:02 ` Shaya Potter
2006-09-05 3:08 ` Trond Myklebust
2006-09-05 3:28 ` Shaya Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44FBD462.1040902@goop.org \
--to=jeremy@goop.org \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=jengelh@linux01.gwdg.de \
--cc=jsipek@cs.sunysb.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.