All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Jonathan Dieter <jdieter@gmail.com>,
	linux-ide@vger.kernel.org, fedora-devel-list@redhat.com
Subject: Re: Kernel fix for ICH7M controller
Date: Mon, 04 Sep 2006 09:34:19 +0200	[thread overview]
Message-ID: <44FBD6FB.4080603@gmail.com> (raw)
In-Reply-To: <44FBBD6F.5060709@garzik.org>

Jeff Garzik wrote:
> Tejun Heo wrote:
>> Jonathan Dieter wrote:
>>> The ata_piix module doesn't detect that my laptop's disk controller 
>>> (Intel Corporation 82801GBM/GHM - ICH7 Family) is configured to have 
>>> PATA drives in the first two channels.  I looked at Intel's 
>>> documentation and they say that my controller isn't supposed to 
>>> support this configuration, but it's the default setup on this 
>>> laptop, there's no way to change it in the BIOS, and it works in 
>>> Windows, so I'm assuming this is a documentation error.
>>>
>>> This patch changes one line in ata_piix.c so that it sees this 
>>> configuration as valid (and therefore recognizes my drives).  I've 
>>> tested it on my laptop and the module is now working perfectly 
>>> (whereas the kernel was using the old IDE driver previously with no 
>>> DMA enabled).
>>
>> Hello,
>>
>> Interesting.  Can you post the result of 'lspci -n -vvv -xxx'?  I 
>> don't see why this support shouldn't go into mainline but wanna see if 
>> narrowing down the effect a bit (if PCI ID allows us to) would be a 
>> good idea.
> 
> FWIW several PCI devices use the ich6m info entry.  We may want to split 
> out ICH7M rather than assume other chips behave similarly.

Hello, Jeff.

The controller is reporting subsystem id 1025(Acer):0107.  Either we can 
enable that entry for all ICH7Ms or only for the Acer.  I'm more 
inclined to the former.  What do you think?

Thanks.

-- 
tejun

-- 
VGER BF report: H 6.45778e-11

  reply	other threads:[~2006-09-04  7:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-03 14:26 Kernel fix for ICH7M controller Jonathan Dieter
2006-09-04  2:47 ` Tejun Heo
2006-09-04  5:45   ` Jeff Garzik
2006-09-04  7:34     ` Tejun Heo [this message]
2006-09-04  6:53   ` Jonathan Dieter
2006-09-04  8:15     ` Tejun Heo
2006-09-04  9:04       ` Jonathan Dieter
2006-09-10 19:54       ` Jonathan Dieter
2006-09-10 21:29         ` [PATCH] ata_piix: add map 01b for ICH7M Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44FBD6FB.4080603@gmail.com \
    --to=htejun@gmail.com \
    --cc=fedora-devel-list@redhat.com \
    --cc=jdieter@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.