From: "Martin Langhoff (CatalystIT)" <martin@catalyst.net.nz>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, Martin Waitz <tali@admingilde.org>
Subject: Re: [PATCH] git-repack: create new packs inside $PACKDIR, not cwd
Date: Mon, 04 Sep 2006 22:03:12 +1200 [thread overview]
Message-ID: <44FBF9E0.9050800@catalyst.net.nz> (raw)
In-Reply-To: <7vr6ysneor.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> In other words...
Can't be offline 2 hs to read a book... ;-) Actually, I had thought the
pack reading code would focus on filenames following pack-<id>.pack
pattern and corresponding idx files, and that .tmp-* was safe to have
there. My bad.
BTW, I think there's a small error.
...
> --- a/git-repack.sh
> +++ b/git-repack.sh
> @@ -24,8 +24,10 @@ do
> shift
> done
>
> -rm -f .tmp-pack-*
> PACKDIR="$GIT_OBJECT_DIRECTORY/pack"
> +PACKTMP="$GIT_DIR/.tmp-$$-pack"
> +rm -f "$PACKTMP"-*
> +trap 'rm -f "$PACKTMP"-*' 0 1 2 3 15
Your packtmp includes $$ which means that rm -f "$PACKTMP" will only
clear out old packs only if the pid of the old-and-probably-dead process
matches ours... and then a hyphen.
so instead I propose...
+trap 'rm -f "$GIT_DIR/.tmp-*-pack"' 0 1 2 3 15
cheers,
martin
--
-----------------------------------------------------------------------
Martin @ Catalyst .Net .NZ Ltd, PO Box 11-053, Manners St, Wellington
WEB: http://catalyst.net.nz/ PHYS: Level 2, 150-154 Willis St
OFFICE: +64(4)916-7224 MOB: +64(21)364-017
Make things as simple as possible, but no simpler - Einstein
-----------------------------------------------------------------------
--
VGER BF report: U 0.900798
next prev parent reply other threads:[~2006-09-04 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 5:42 [PATCH] git-repack: create new packs inside $PACKDIR, not cwd Martin Langhoff
2006-09-04 9:08 ` Martin Waitz
2006-09-04 9:36 ` Junio C Hamano
2006-09-04 9:50 ` Junio C Hamano
2006-09-04 10:03 ` Martin Langhoff (CatalystIT) [this message]
2006-09-04 10:13 ` Junio C Hamano
2006-09-04 10:46 ` Martin Langhoff (CatalystIT)
2006-09-04 20:16 ` Junio C Hamano
[not found] <1157337502104-git-send-email-martin@catalyst.net.nz>
2006-09-04 2:42 ` Martin Langhoff (CatalystIT)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44FBF9E0.9050800@catalyst.net.nz \
--to=martin@catalyst.net.nz \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=tali@admingilde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.