From: Bill Davidsen <davidsen@tmr.com>
To: adam radford <aradford@gmail.com>
Cc: Jim Klimov <klimov@2ka.mipt.ru>,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org
Subject: Re: 3ware glitches cause softraid rebuilds
Date: Mon, 04 Sep 2006 12:59:20 -0400 [thread overview]
Message-ID: <44FC5B68.7080500@tmr.com> (raw)
In-Reply-To: <b1bc6a000608281756s1e76a80eq5f70e654e2e7e3e3@mail.gmail.com>
adam radford wrote:
> Jim,
>
> Can you try the attached (and below) patch for 2.6.17.11?
Don't you want the sleep BEFORE setting the new value? ie. giving a wait
for status to change before checking it again?
>
> Also, please make sure you are running the latest firmware.
>
> Thanks,
>
> -Adam
>
> diff -Naur linux-2.6.17.11/drivers/scsi/3w-9xxx.c
> linux-2.6.17.12/drivers/scsi/3w-9xxx.c
> --- linux-2.6.17.11/drivers/scsi/3w-9xxx.c 2006-08-23
> 14:16:33.000000000 -0700
> +++ linux-2.6.17.12/drivers/scsi/3w-9xxx.c 2006-08-28
> 17:48:29.000000000 -0700
> @@ -943,6 +943,7 @@
> before = jiffies;
> while ((response_que_value & TW_9550SX_DRAIN_COMPLETED) !=
> TW_9550SX_DRAIN_COMPLETED) {
> response_que_value =
> readl(TW_RESPONSE_QUEUE_REG_ADDR_LARGE(tw_dev));
> + msleep(1);
> if (time_after(jiffies, before + HZ * 30))
> goto out;
> }
>
>------------------------------------------------------------------------
>
>diff -Naur linux-2.6.17.11/drivers/scsi/3w-9xxx.c linux-2.6.17.12/drivers/scsi/3w-9xxx.c
>--- linux-2.6.17.11/drivers/scsi/3w-9xxx.c 2006-08-23 14:16:33.000000000 -0700
>+++ linux-2.6.17.12/drivers/scsi/3w-9xxx.c 2006-08-28 17:48:29.000000000 -0700
>@@ -943,6 +943,7 @@
> before = jiffies;
> while ((response_que_value & TW_9550SX_DRAIN_COMPLETED) != TW_9550SX_DRAIN_COMPLETED) {
> response_que_value = readl(TW_RESPONSE_QUEUE_REG_ADDR_LARGE(tw_dev));
>+ msleep(1);
> if (time_after(jiffies, before + HZ * 30))
> goto out;
> }
>
>
--
bill davidsen <davidsen@tmr.com>
CTO TMR Associates, Inc
Doing interesting things with small computers since 1979
prev parent reply other threads:[~2006-09-04 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-28 23:46 3ware glitches cause softraid rebuilds Jim Klimov
2006-08-29 0:25 ` adam radford
2006-08-29 0:56 ` adam radford
2006-09-04 16:59 ` Bill Davidsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44FC5B68.7080500@tmr.com \
--to=davidsen@tmr.com \
--cc=aradford@gmail.com \
--cc=klimov@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.